ugent-library / biblio-backoffice

Apache License 2.0
7 stars 0 forks source link

Add publication year to dashboard #914

Closed mietcls closed 1 year ago

mietcls commented 1 year ago

Story

Add publication year to dashboard

Context

In the old Biblio the reviewers had the option to filter on year in the dashboard. We have not implemented this yet, but the functionality is apparently more and more pressing to be able to do reviews for deadlines.

Image

The dashboard story: https://github.com/ugent-library/biblio-backoffice/issues/517

Current situation

Image

Desired situation

Out of scope:

Image

Example: Image

Suggested implementation

Inside the card header:

<div class="card-header">
    <div class="bc-toolbar">
        <div class="bc-toolbar-left">
            <h3 class="card-title">Public with classification U</h3>
        </div>
        <div class="bc-toolbar-right text-align-right">
            <div>
                <label class="col-form-label sr-only">Select year</label>
                <select class="custom-select w-100">
                    <option>All years</option>
                    <option>Publication year missing</option>
                    <option>2023</option>
                    <option>2022</option>
                    <option>2021</option>
                    <option>2020</option>
                    <option>....</option>
                </select>
            </div>
        </div>
    </div>
</div>
nicolasfranck commented 1 year ago

@mietcls this is the "publication year", right?

I also suspect that that label "Select year" is unnecessary? It takes up too much vertical space in an already small space.

mietcls commented 1 year ago

@nicolasfranck yes, edited ;-)

nicolasfranck commented 1 year ago

@mietcls @netsensei sigh, what I also see is that there is a select box for every table. Selecting that should update the tabel below it, right? But if I would implement this using the existing setup, a select would reload the page, after which you would have to scroll to the right table again..

mietcls commented 1 year ago

Providing this for "Public with classification U" is most important, as this one is used most. So the scrolling issue won't be that impactful. This feature is for librarians only. I can check if it's okay to only do this for the first table. Please confirm if this is helpful.

nicolasfranck commented 1 year ago

@mietcls the code for "publications with U" and "publication with accepted" are all in the same place. But no worries, I have a solution

nicolasfranck commented 1 year ago

Datasets do not have an attribute year (there is no facet for that reason)

nicolasfranck commented 1 year ago

@mietcls when I click on the year button, the table is reloaded in the background. But to an end user it is not so clear that the table is being reloaded, as there is no loading bar. Is there a way to put some half transparent layer over the table to make clear that it is loading something?

mietcls commented 1 year ago

Can you use this @nicolasfranck? https://github.com/ugent-library/biblio-backoffice/issues/610

nicolasfranck commented 1 year ago

@mietcls would be better to have something hovering over the existing table (which will be swapped out by the new table eventually). Will assign to a ticket once this is merged.