search

ugent-library / deliver

Apache License 2.0
3 stars 0 forks source link

Add hotkey to new folder form #134 #140

Closed verheyenkoen closed 5 months ago

verheyenkoen commented 6 months ago

This PR adds hotkey functionality to the folder view on the "Make new folder" button as described in #134.

verheyenkoen commented 6 months ago

@mietcls One problem I identified is, if you hit the "n" hotkey while uploading files, you are redirected and all incomplete uploads are lost. Since this is also the case if you navigate away in another manner (eg. clicking a link), I decided not to fix that in the scope of this ticket.

Instead I suggest we add a confirm step when leaving the page during uploads. This can be done by adding/removing an event handler for the beforeunload event.

mietcls commented 5 months ago

Thank you, works as expected! Created a new issue based on your remark, a good enhancement: https://github.com/ugent-library/deliver/issues/142 Feel free to improve it / provide feedback.

verheyenkoen commented 5 months ago

@nics Can you review and merge this?