Dockerfile should be exactly same as oai-service

[netsensei]

Last 5 lines in the current Dockerfile reads:

WORKDIR /opt/people-service
COPY --from=build /opt/people-service/people-service .
COPY --from=build /opt/people-service/public public
CMD mkdir -p api/v1
COPY --from=build /opt/people-service/api/v1/openapi.yaml /opt/people-service/api/v1/

• There's no need to push the binary in a dedicated /opt directory in a Docker context
• There's no need to call the binary people-service within the Docker image; because it's not possible to shell into the container and execute the binary directory. Just app suffices.
• There should be no need to separately copy the public directory and the YAML file.

OAI service does it like this:

RUN go build -o app -v

etc...

WORKDIR /dist
COPY --from=build /build .
EXPOSE 3000
CMD ["/dist/app", "app"]

Last bullet point: the openapi.yaml file is automatically copied into the container. It should be automatically picked up.

[nicolasfranck]

@netsensei well have a look at the contents in the docker instance of the oai-service-dev (I just had a look in the running container over ssh):

/dist # ls
Dockerfile           cli                  oaipmh
LICENSE              ent                  public
Makefile             go.mod               reflex.conf.example
README.md            go.sum               repositories
api                  hooks
app                  main.go
/dist 

all of the development files are also there. You have to pick and choose what to copy.

About the naming and location of the binary: no idea. I tend to keep names recognizable. What is the hell is app?

[nicolasfranck]

BTW this looks more like a discussion, not?