search

ugexe / zef

Raku Module Management
Artistic License 2.0
206 stars 44 forks source link

zef not coping with parental controls / filters / proxies doing wrong things #292

Open lizmat opened 5 years ago

lizmat commented 5 years ago

It looks like zef has a bad failure mode if the file obtained from the ecosystem is being blocked / redirected / replaced by garbage that is not the right JSON: like the ecosystem is empty.

Spotted at the GPW of which the WiFi apparently had some parental controls enabled on one of the outer routers.

ugexe commented 5 years ago

https://github.com/ugexe/zef/blob/7c9d05bd1a04baed844d7676605fc2a2452e5a3a/lib/Zef/Repository/Ecosystems.pm6#L94

The above should probably fail if it gets invalid json. So this should probably throw, and be caught inside Zef::Repository (where it gets called) to deliver the exception message via $logger.emit(...).

tbrowder commented 2 years ago

Is this issue closable?