feat: add support to `conventional-changelog` v3 and `lerna` v3

uglow / conventional-changelog-angular-bitbucket

Angular conventional-changelog preset for BitBucket repositories

Other

12 stars 12 forks source link

feat: add support to `conventional-changelog` v3 and `lerna` v3 #13

Closed peterbakonyi05 closed 5 years ago

peterbakonyi05 commented 6 years ago

Lerna 3 cannot be used with the latest version of this packages because the versioning will not be correct. When comparing the public api of conventional-changelog-angular v5 and conventional-changelog-angular-bitbucket, there are missing properties. This PR adds support for those missing properties.

Note: it seemed cleaner to depend on conventional-changelog-angular to expose the recommendedBumpOpts property rather than copy pasting that code from `convetional-changelog-angular (less duplication, more future proof and no need to write additional specs to verify that logic).

Testing it locally with lerna v3.4.3, with these changes, it works as expected.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 83f88695219a213bb245bb00b33681fd30f302f3 on peterbakonyi05:feature/support-conventional-changelog-3 into e94594e35fbbe92268782dab95682f35c2d609d7 on uglow:master.

peterbakonyi05 commented 6 years ago

@uglow Could you kindly give some feedback when you will have time to take a look at the PR?

uglow commented 6 years ago

Thanks @peterbakonyi05 👍🏻

peterbakonyi05 commented 5 years ago

@uglow Can you please merge the PR as Only those with write access to this repository can merge pull requests. :)

uglow commented 5 years ago

Merged! Thanks @peterbakonyi05

peterbakonyi05 commented 5 years ago

@uglow Thank you for merging! When could it be released in a new stable version?

uglow commented 5 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: