fix: repoUrl should include a trailing slash

uglow / conventional-changelog-angular-bitbucket

Angular conventional-changelog preset for BitBucket repositories

Other

12 stars 12 forks source link

fix: repoUrl should include a trailing slash #6

Closed cecilia-sanare closed 7 years ago

cecilia-sanare commented 7 years ago

Adds a trailing slash when repoUrl is used.

closes #5

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling cd71012f5556c5d1d80ddbfaffa9ec7450dcf17e on nick-woodward:missing-slashes into 9b5c239b7952e6d97661a4d0fe16bad9483502bb on uglow:master.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling cd71012f5556c5d1d80ddbfaffa9ec7450dcf17e on nick-woodward:missing-slashes into 9b5c239b7952e6d97661a4d0fe16bad9483502bb on uglow:master.

cecilia-sanare commented 7 years ago

Forgot to add a unit test, I'll write one after work.

uglow commented 7 years ago

Approved subject to unit test, Nick 👍

cecilia-sanare commented 7 years ago

@uglow Thanks for the reminder! I updated the PR with a unit test.

I also had to update conventional-changelog-core in order to test this scenario.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling ac0b8e45587a7efff2329a3d19dd93da4f81ce0f on nick-woodward:missing-slashes into 9b5c239b7952e6d97661a4d0fe16bad9483502bb on uglow:master.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling ac0b8e45587a7efff2329a3d19dd93da4f81ce0f on nick-woodward:missing-slashes into 9b5c239b7952e6d97661a4d0fe16bad9483502bb on uglow:master.

cecilia-sanare commented 7 years ago

@uglow When you get the chance can you look over this PR? Thanks!

uglow commented 7 years ago

Approved subject to clarifying the added test (see comment above). Thanks Nick.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling 58276dedce4505da3965112308eec096ad296037 on nick-woodward:missing-slashes into 9b5c239b7952e6d97661a4d0fe16bad9483502bb on uglow:master.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling 93a631cd722dbe2937345d2b20c44d39b1dbfb86 on nick-woodward:missing-slashes into 9b5c239b7952e6d97661a4d0fe16bad9483502bb on uglow:master.