fix(build): update bitbucket url schemes

cwhenderson20 commented 7 years ago

This PR updates the URL scheme in the the templates to match the current Bitbucket spec. I know that Bitbucket has recently undergone a redesign and this is likely when they changed their scheme.

I didn't tag this commit as a feature because it doesn't feel like one, but if you feel it makes more sense to tag it with a major version in case the old scheme is still valid for some users, I'll be happy to update the PR.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling 1042cc5587ca08aa5c1ffc4d6799733f3b68fe08 on cwhenderson20:update-url-scheme into 1a4547b47c9924ea59d36fd448aa0c43cca11a15 on uglow:master.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling 1042cc5587ca08aa5c1ffc4d6799733f3b68fe08 on cwhenderson20:update-url-scheme into 1a4547b47c9924ea59d36fd448aa0c43cca11a15 on uglow:master.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling df7e9dbdc354b14ae76ebbfe876c4400034a456c on cwhenderson20:update-url-scheme into 1a4547b47c9924ea59d36fd448aa0c43cca11a15 on uglow:master.

coveralls commented 7 years ago

Coverage remained the same at 97.917% when pulling df7e9dbdc354b14ae76ebbfe876c4400034a456c on cwhenderson20:update-url-scheme into 1a4547b47c9924ea59d36fd448aa0c43cca11a15 on uglow:master.

uglow commented 7 years ago

Thanks @cwhenderson20 . Looking at the changes, you may be able to use the regular conventional-changelog-angular package instead of this one for the new BitBucket spec. Are you able to:

test whether the ordinary "angular" preset works for the new BitBucket repos (possibly commit references may not link correctly). If that does work, then there's no need to make changes to this repo other than to update the readme (and perhaps the compare-order change you've made) to indicate this is for older BitBucket repos.
provide a link to the new BitBucket repo URL spec

If the "angular" preset does not work with the new repo ULR spec, I'll mark it is a breaking change (it is not backwards compatible for people using previous versions of BitBucket).

Thanks again @cwhenderson20 👍

cwhenderson20 commented 7 years ago

@uglow, I did try the standard angular convention before searching for this preset. The commits actually link correctly, but the version header (compare two tags) does not. It appears that GitHub uses the .. sequence to separate tags whereas Bitbucket uses the %0D sequence.

I'm not sure, however, about other differences such as auto-linking ticket numbers and @ mentions.

As per documentation, this is the best I can find at the moment (since the URL structure isn't an API, it's not really documented) — with the relevant portion being:

Each username is unique throughout Bitbucket Cloud. Your username appears in the URL for your personal repositories, as in https://bitbucket.org/<username>/<repository>.

uglow commented 7 years ago

Thanks for following up @cwhenderson20. Given there's no way of having backwards compatibility (between the old URL schema and the new one), this is what I suggest:

Create another PR that contains just the reverse-compare-order change. This PR will be merged first as the change is for both the current Bitbucket and future Bitbucket code
Change this PR to just contain the schema changes (not the reverse-compare-order change). This PR will be merged last and will be identified as a breaking change.

bertho-zero commented 6 years ago

Any news of this ?

uglow commented 6 years ago

@cwhenderson20 @bertho-zero Do you want to move forward with these changes? If so, this is what needs to happen:

Resolve the current merge conflicts appropriately
Create a commit with BREAKING CHANGES so that a new major version of the library will be generated when this branch is merged to master. The breaking changes should document new BitBucket commit-link and compare-link format.
Update the readme file to also document the new BitBucket commit-link and compare-link format

Thanks!

cwhenderson20 commented 6 years ago

@uglow Yes, I think it should be easy enough to make those changes. I'll create a new PR that just contains the reverse compare order changes and then update this one to include a breaking change for the new link formats.

Just a note: I'm quite busy, so I may not get to it until later in the week.

KyleLNicholls commented 5 years ago

I was under the impression the conventional-changelog-angular-bitbucket is setup to support Bitbucket Server. The change you are proposing would change this plugin to support Bitbucket Cloud instead. They are two different products with two different url schemes for repos.

Bitbucket Server, as far as I'm aware, still uses https://<host>/projects/<projectid>/repos/<repoid> Bitbucket Cloud uses https://bitbucket.org/<username>/<repository> The both also have different schemes for comparing tags.

uglow commented 3 years ago

Closing due to lack of progress/need.

uglow / conventional-changelog-angular-bitbucket

fix(build): update bitbucket url schemes #7