search

uglycustard / buildergenerator

A tool to auto generate builders following the Builder pattern for an object graph of JavaBeans.
Apache License 2.0
5 stars 2 forks source link

Fixes #33 Incorrect code generated for property Map<String, Bar> #34

Closed azzoti closed 9 years ago

azzoti commented 9 years ago

In BuilderGeneratorIT#readFiles I added line = line.trim(); which allowed the tests to pass on machine at work, otherwise I got space differences.

I also added test BuilderGeneratorIT#beanWithCollectionAlsoGeneratesBuilderForGenericType to check that Address#List generates HouseBuilder class which is nothing to do with the issue #33.

uglycustard commented 9 years ago

You've added the deleteGeneratedFiles method to FileUtils which is hard coded to the integration test folder - but FileUtils is in main and part of the application. I think this delete method which only appears to be invoked from the IT should be moved to a private method in the IT class.

azzoti commented 9 years ago

done I think - blimey this git stuff is complicated!

uglycustard commented 9 years ago

Cool, I'm away this weekend but will pull it in on Sunday and release it. Cheers.

Sent from Yahoo Mail on Android

From:"Tim Azzopardi" notifications@github.com Date:Thu, 17 Sep, 2015 at 21:28 Subject:Re: [buildergenerator] Fixes #33 Incorrect code generated for property Map (#34)

done I think - blimey this git stuff is complicated!

— Reply to this email directly or view it on GitHub.

uglycustard commented 9 years ago

Release 0.0.21