search

ugorji / go

idiomatic codec and rpc lib for msgpack, cbor, json, etc. msgpack.org[Go]
MIT License
1.86k stars 295 forks source link

Zero-copy not working because Decoder.bytes is never set #193

Closed bboreham closed 7 years ago

bboreham commented 7 years ago

It is read in various decoders, e.g. at https://github.com/ugorji/go/blob/master/codec/msgpack.go#L730, but there is no code where bytes is set.

This has the effect that most of the zero-copy code in msgpack.go is never called.

bboreham commented 7 years ago

That fix is not effective because it is called after the value of bytes is read.

ugorji commented 7 years ago

Sorry - incomplete fix. Please try now.

bboreham commented 7 years ago

Yes, that works, thanks.