ugorji / go

idiomatic codec and rpc lib for msgpack, cbor, json, etc. msgpack.org[Go]
MIT License
1.86k stars 295 forks source link

go.mod says it requires Go 1.13 (erroneously) #288

Closed ytwig closed 5 years ago

ytwig commented 5 years ago

Latest commit seems to break things. Trying to build a project based of GIN router that has dependency on go-codec, and getting this error go build github.com/ugorji/go/codec: module requires Go 1.13

Any suggestions?

ugorji commented 5 years ago

@ytwig

I need a reproducer:

This way, I can reproduce it here and try to help.

ugorji commented 5 years ago

Please try again.

The go command, behind the scenes, updates the go.mod file to specify a release version. Now removed.

ytwig commented 5 years ago

The latest commit added the go.mod file with a dependency "go 1.13". When you try to build a simple project that imports "github.com/ugorji/go/codec", it fails

For example

`package main

import( "fmt" "github.com/ugorji/go/codec" )

func main(){ decode := codec.Decoder{} fmt.Print(decode) } `

ytwig commented 5 years ago

Thanks :)

ugorji commented 5 years ago

@ytwig please let me know if that works.

ytwig commented 5 years ago

@ugorji still fails. You need to update/make new release (technically i can set the latest commit as the release, but would be better to just have it in a release)

ugorji commented 5 years ago

Please try again with 1.1.4

ytwig commented 5 years ago

Works :) Thanks