search

ugorji / go

idiomatic codec and rpc lib for msgpack, cbor, json, etc. msgpack.org[Go]
MIT License
1.86k stars 295 forks source link

Tag v1.1.5-pre does not exist anymore #337

Closed rbretecher-fcms closed 4 years ago

rbretecher-fcms commented 4 years ago

Hello,

Since today, we are experiencing build issues with our application and it seems that it's because the tag v1.1.5-pre of your Go module is missing. This module is an indirect dependency used by Gin and we're not sure we can upgrade Gin to use a later version.

As I'm not sure this is the issue, could you tell me if you recently removed this tag ?

Thanks for your help.

gngchrs commented 4 years ago

my build also failed. fixed with

go mod edit --replace github.com/ugorji/go@v1.1.5-pre=github.com/ugorji/go@v1.1.6

ugorji commented 4 years ago

This was a pre-release tag that I was using to test out modules over a year ago. I was confident (incorrectly) that no one depended on it. My apologies.

I just took a look at Gin and it's go.mod references v1.1.7.

Maybe there's something else that is dragging v1.1.5-pre? Im hoping we can track that down quickly, before having to resort to re-creating the tag.

ugorji commented 4 years ago

Also checked the go.sum file, and it references v1.1.7

Correction: the go.mod also references v1.1.7

Not sure why you are seeing v1.1.5-pre . Can you please try to deduce further?

gngchrs commented 4 years ago

@ugorji mine came from http-swagger, whose dependency graph was like below.

Screenshot 2020-10-14 at 08 23 32
rbretecher-fcms commented 4 years ago

@ugorji Actually, I built a dependency graph graph using depth tool ( https://github.com/KyleBanks/depth ) and the only module that uses your module is Gin so I assumed this was coming from Gin.

@gngchrs Could you tell me how you managed to build this dependency graph ?

gngchrs commented 4 years ago

@rbretecher-fcms I only have github.com/swaggo/http-swagger as a dependency in my go.mod, and my builds started failing yesterday. The image posted above is what I see when the build fails.

rbretecher-fcms commented 4 years ago

@gngchrs I see, thanks for you answer :)

I just upgraded the module and this finally solved my issue :

go get -u github.com/ugorji/go
ugorji commented 4 years ago

I found a way to restore the tag. Luckily, github release allowed me have a hanging release, and still held onto the tag. I have now restored v1.1.5-pre. Please retry and confirm.

Still, let's have the other users upgrade, so that I can eventually remove this. I was hoping pkg.go.dev could tell who is using a specific version, but I couldn't find that.

ugorji commented 4 years ago

See https://github.com/ugorji/go/tree/v1.1.5-pre