default install exposes MySQL

[sparrowme]

In testing a new install it appears Mysql is actually exposed with the defaults from docker-compose.yml

    ## WARNING: if commented out, the database will be exposed outside the container
    ports:
    - ${APP_PORT_MYSQL}:3306

Did I miss an install step that forces docker to bind only to 127.0.0.1 for mysql? It appears the above warning should read... "not commented out" or was another meaning intended?

However, I fixed it with...

    ## WARNING: if commented out, the database will be exposed outside the container
    ports:
    - 127.0.0.1:${APP_PORT_MYSQL}:3306

but following the new install steps Mysql was infact exposed with a bind to 0.0.0.0

[ugoviti]

True, it's a typo, thank you for the suggestion.

updated with the last commit

[sparrowme]

Thanks! Just wondering... would it be better to force that bind in the docker-compose.yml to 127.0.0.1 so what I did wouldn't happen "by default"? Is there actually a real need to expose 3306 on all interfaces by default? I can see how a dev environment might want direct access...