As we introduce more buildings officially into the tool, it becomes more complex to define the default spaces. Even if we want to overwrite the spaces of a predefined environment, this can be very extensive in the code.
In this PR, it is proposed to migrate spaces, variables and reward definition for pre-configured environments to JSON files, one per each building model type. These JSON will have all the configuration required for continuous and discrete environments (except action mapping functions for discrete environments, since these functions are not pretty in JSON format).
Motivation and Context
[x] I have raised an issue to propose this change (required for new features and bug fixes)
Fixes #365
For more information about motivation, read the closed issue.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Description
As we introduce more buildings officially into the tool, it becomes more complex to define the default spaces. Even if we want to overwrite the spaces of a predefined environment, this can be very extensive in the code.
In this PR, it is proposed to migrate spaces, variables and reward definition for pre-configured environments to JSON files, one per each building model type. These JSON will have all the configuration required for continuous and discrete environments (except action mapping functions for discrete environments, since these functions are not pretty in JSON format).
Motivation and Context
Fixes #365
For more information about motivation, read the closed issue.
Types of changes
Checklist:
autopep8
second level aggressive.isort
.cd docs && make spelling && make html
pass (required if documentation has been updated.)pytest tests/ -vv
pass. (required).pytype -d import-error sinergym/
pass. (required)Changelog:
action_mapping
functions for discrete environments).__init__.py
) for the new register system with these JSON files.Extra: