ugroot / GROOT

GROOT: Welcome to my source code, I'm your personal assistant
Mozilla Public License 2.0
27 stars 28 forks source link

Fixed All The Layout Anomalies and Added News Api Function. #33

Closed plusminuschirag closed 5 years ago

plusminuschirag commented 5 years ago

The Gui was in very very initial stage. Sorted all the functionalities and create purely OOPS based implementation of widgets and layouts. Main Layout is clean and easy to read now.

Added Size hints to fields so they can detect the change in window.

Added News-Api:

techytushar commented 5 years ago

Great Work!! But there is a small bug, when I type the input and press enter the app shutsdown, please fix that.

plusminuschirag commented 5 years ago

I will surely look into it, can you post your error log?

techytushar commented 5 years ago

So here is the error logs, when I press enter after typing into the text box I get the following error:

serror

Also while starting the application sometimes it gives this error, this might be because my internet connection was not good or the API you are using has some request limits

Screenshot from 2019-03-19 22-01-07

IMO the news feature in the app is not very useful and it also makes the app opening time quite long. We can display news when the user asks Groot to show them the news but showing it beforehand is not very useful. What do you think @omi10859

omi10859 commented 5 years ago

if you have changed GUI you should add screenshots

plusminuschirag commented 5 years ago

Screenshot from 2019-03-22 10-32-35

Here it is.

omi10859 commented 5 years ago

When I run python base.py it takes time to open may be because you are fetching all the news from API and it does takes time. (Improve) [Changes] 1)Groot should start with a minimul design you can add a button when clicked on the button it will open a box with a news section.

omi10859 commented 5 years ago

newsLibrary.py should be inside asset/modules/

lalitmee commented 5 years ago

Yeah @omi10859, you are right it should open with a minimal UI so that it will look clean and simple to use for the User. :+1:

plusminuschirag commented 5 years ago

Working on it.

plusminuschirag commented 5 years ago

Hi @omi10859 Please have a look. I have seprated them. Now Groot is minimal again and News are loaded seprately. Sometimes the news part crashes it because of limited call system but that can also be new issue for Groot.

I have removed the commented code. It's clean again and the newsApi belongs to module now. Screenshot from 2019-03-24 23-49-42

omi10859 commented 5 years ago

Will check and let you know. Meanwhile, create a new issue and start working on that Things that need to be fixed

plusminuschirag commented 5 years ago

So press the speak button and say "news -------" which can be a specific keyword or a sentence it will treat them as keywords".

Ex : "news sports", "news India".

omi10859 commented 5 years ago

I'm getting this error

Traceback (most recent call last): File "/Users/omkaryadav/Documents/projects/testhere/GROOT/Gui.py", line 50, in createNewsLayout self.newsWindow = newsBox() File "/Users/omkaryadav/Documents/projects/testhere/GROOT/newsWindow.py", line 14, in __init__ self.initUI() File "/Users/omkaryadav/Documents/projects/testhere/GROOT/newsWindow.py", line 19, in initUI self.lowerLayout = TabLayout() File "/Users/omkaryadav/Documents/projects/testhere/GROOT/newsWindow.py", line 55, in __init__ self.myLabel = Tiles(parent="None",description = article['description'][0:100],title=article['title'],url=article['url'],urlImage=article['urlToImage']) File "/Users/omkaryadav/Documents/projects/testhere/GROOT/newsWindow.py", line 72, in __init__ data = urllib.request.urlopen(urlImage).read() File "/Users/omkaryadav/.pyenv/versions/3.6.0/lib/python3.6/urllib/request.py", line 223, in urlopen return opener.open(url, data, timeout) File "/Users/omkaryadav/.pyenv/versions/3.6.0/lib/python3.6/urllib/request.py", line 517, in open req.timeout = timeout AttributeError: 'NoneType' object has no attribute 'timeout' [1] 30056 abort python base.py

plusminuschirag commented 5 years ago

Screenshot from 2019-04-02 21-09-36 It's working fine in my case. Maybe the request timed out because of traffic. This is my guess

plusminuschirag commented 5 years ago

@omi10859 I said "news sports".

plusminuschirag commented 5 years ago

Any updates?

plusminuschirag commented 5 years ago

Issue #36 was also linked with it. Please close it too. They were on same branch