ugroot / GROOT

GROOT: Welcome to my source code, I'm your personal assistant
Mozilla Public License 2.0
27 stars 28 forks source link

Executable file for linux added to /dist/base called base #53

Open aish-where-ya opened 5 years ago

aish-where-ya commented 5 years ago

This executable is for 64bit Linux OS

techytushar commented 5 years ago

Nice work! Instead of adding all these files you can use the --onefile option of pyinstaller to just generate a single file, that would be easier and less bulky.

aish-where-ya commented 5 years ago

It increases the size of executable file from 3.12 MB to 148.5MB. This makes it difficult to push and it needs a large file tracker (git lfs). What do you prefer?

techytushar commented 5 years ago

I would suggest to keep one file, since when I tried to run the base file it was giving package errors, but when I compiled all into one file it ran fine. Tagging other mentors for suggestions: @omi10859 @lalitmee

lalitmee commented 5 years ago

Actually, it would be better if we use a single file. :+1:

aish-where-ya commented 5 years ago

The executable files are greater than 100MB so they need to be tracked using git lfs. According to Github's guidelines, this repo needs to have atleast 1 lfs object which has been already pushed by the owner so that other contributors can add large files using public forks. Due to security issues, public forks cannot add large files unless there already exist some in the repo. Please suggest a workaround to this problem.