ugurdogrusoz / visuall

Visuall: A tool for convenient construction of a web based visual analysis component
2 stars 0 forks source link

Predefined lists to be used in queries #302

Closed canbax closed 3 years ago

canbax commented 4 years ago

A possible feature explained in https://docs.google.com/document/d/1Vrlb2jFg0b_oiqVvXg0O9iR9_x9UYsD1sTYdwly1hSc/edit?usp=sharing

canbax commented 4 years ago

I added English translation for google document.

ugurdogrusoz commented 4 years ago

Left my questions / comments in the associated doc.

canbax commented 4 years ago

To store values, we are using localStorage. So to save predefined lists, "Store user profile" setting should be checked.

ugurdogrusoz commented 4 years ago

Looks good in general, some improvements:

canbax commented 4 years ago

There is a list data type in Neo4j. We use the in operator for list types. In fact, we only have in operator for list types.

On the other hand, one of operator just makes a condition similar to Person.name == 'John' OR Person.name == 'Jack' ... so we simply combine equality checks with OR statements in Cypher.

ugurdogrusoz commented 4 years ago

I think when the user clicks "Add/Update list" the predefined list should be properly added/updated but the value of the current condition is unchanged if the user exits with "Cancel" instead of "OK".

ugurdogrusoz commented 4 years ago

When the predefined list name is arbitrarily long, dropdown can be arbitrarily wide:

Screen Shot 2020-10-27 at 18 01 12

Let's limit the width to not exceed the dialog width using ellipses (...)

canbax commented 3 years ago

Limiting or changing the width of an HTML option tag is somehow not working. So I set a length limit (33) for the input which will generate options. The width of a character in pixels depends on character and font-size. So I give an approximate value.