search

ugurdogrusoz / visuall

Visuall: A tool for convenient construction of a web based visual analysis component
2 stars 0 forks source link

Unnecessary animation on expand/collapse with timebar #316

Closed ugurdogrusoz closed 4 years ago

ugurdogrusoz commented 4 years ago

Normally when we expand or collapse a compound we animate the changes and fit it window. Similarly, when there is a change in the graph and the timebar is enabled, we also do an incremental layout and fit in window. I think these are both happening somehow resulting in bad looking animation: ezgif com-gif-maker (1)

Let's not fit in window after an expand or collapse (this is what we do in Newt, which works nicely). This might resolve this issue.

canbax commented 4 years ago

I set fit option to false in fcose. So after expand/collapse, it won't fit the window. But still it will run fcose. So with timebar enabled, timebar will also call layout.

So again we will do 2 layouts very frequently. One will fit window, the other won't. Maybe we can force it to make only 1 call to layout.

Also, now when we expand/collapse the layout won't fit in to the window. It was like this in newt.