search

ugurdogrusoz / visuall

Visuall: A tool for convenient construction of a web based visual analysis component
2 stars 0 forks source link

Timebar settings are not coming from user-profile saved in localStorage #317

Closed canbax closed 3 years ago

canbax commented 4 years ago

Currently, we are passing settings to timebar extension with this line

const s = AppDescription.appPreferences.timebar; // settings for timebar

Here we are reading static settings from the "app_description.json" file. We should care about the dynamic settings that are saved in the user profile.

Also, I think we should add the new time bar setting graphRangeRatio to the time bar settings UI as well. Otherwise, it won't be dynamic as well

--edit-- Since we are reading user settings later, we would update them later. So actually there is no bug. --edit2-- Since the timebar extension initialized later when data is loaded and if the extension is enabled, the settings will be taken from the "app_description.json" file. So there is a bug.