Closed LaraMerdol closed 1 year ago
However, this type of id is not a proper selector id because it is also used as a CSS selector
You mean it is not a valid cytoscape.js selector. Right? If so where does these selectors are used? As far as I remember, they are only used in highlighting elements on hover. If it's the case, why don't we select them with selectors like [id = 'foo']
as stated https://js.cytoscape.org/#selectors/group-class-amp-id
Always replacing elementIds seems high maintenance to me. Also I see that elementId is just a string and it can be a cytoscape.js element id.
However, this type of id is not a proper selector id because it is also used as a CSS selector
You mean it is not a valid cytoscape.js selector. Right? If so where does these selectors are used? As far as I remember, they are only used in highlighting elements on hover. If it's the case, why don't we select them with selectors like
[id = 'foo']
as stated https://js.cytoscape.org/#selectors/group-class-amp-idAlways replacing elementIds seems high maintenance to me. Also I see that elementId is just a string and it can be a cytoscape.js element id.
Yes, you are right. I changed the selectors as you suggested. Now all elementIds are in the same format without any replacements used.
1-) In some places, there might be some performance regression. O(n) is replaced with O(n^2). I think those can be done in O(n)
2-) I don't have access to deployed visual env. Please test there
3-) some time ago, there were Cypress e2e tests. Do they still run? If so, can you run them
4-) As an improvement those Cypress test could be run as a new step of the current Github Action
If you do points 1 & 2 I think it's good to merge. 3 & 4 could be future improvements. But if you could do point 3, it would be great to see this big change doesn't cause any bugs.
I'd like to inform you of the following updates:
I have made changes to the visual application in response to the issues mentioned in #387. The modifications involve using Neo4j version 5.10. Here are the details of the changes made:
For testing on your local environment, you can use the new Neo4j 5.10 database working on the ivis server port:3001. The credentials are username: neo4j and password: 12345678. You should change the environment.ts accordingly.