Revamped UI Design of on-boarding page

theGeekyLad commented 3 years ago

Highlights

Fixed build throwing an error at holder.binding.rootView ... in HomeFragment.java under onBindViewHolder(), that rootView is has only private access - updated that to holder.binding.getRoot ...
Added official Material Design dependencies and replaced existing TextViews, EditTexts etc. with Material components
Changed look and feel of activity_onboading.xml to match standards
- Based on whether student or staff, edit fields are shown / hidden
- Added validation to btnVerify in OnboardingActivity.java which is automatically disabled if editRegNum or editStaffId is empty
Removed textColor from activity_onboarding.xml to fix issues in dark mode

Screenshots

Light Mode

light

Dark Mode

dark

ugwulo commented 3 years ago

Impressive @theGeekyLad kudos to you on a good job👍 Please do well to address the issue I pointed out

ugwulo commented 3 years ago

@theGeekyLad it is also important to note that PRs should focus on a single issue. Feel free to submit different PRs for other issues for easy tracking

theGeekyLad commented 3 years ago

Thanks a bunch for your review comments @ugwulo ! Helps a lot for a newbie like me indeed. Should I raise another PR with the udpated README.md?

ugwulo commented 3 years ago

Yea sure, do well to raise another PR @theGeekyLad

theGeekyLad commented 3 years ago

Also, is there a test reg. no. that I could use to sign in and check the other screens too?

ugwulo commented 3 years ago

Yes, here it is 18EH/0059/CS @theGeekyLad

theGeekyLad commented 3 years ago

Hey @ugwulo , thanks for the ID for testing. :smile: Also, I've dropped the unnecessary files. Is this PR good to go?

ugwulo / LectureNote