search

uhaciogullari / SimpleMvcSitemap

A minimalist library for creating sitemap files inside ASP.NET MVC and ASP.NET Core MVC applications
MIT License
128 stars 39 forks source link

Missing await in ExecuteResultAsync of XmlResult #41

Closed wojcichy closed 4 years ago

wojcichy commented 4 years ago

This line should be awaited: https://github.com/uhaciogullari/SimpleMvcSitemap/blob/02198ace4864cef9b08ae721bda82640f38d3d7e/src/SimpleMvcSitemap/XmlResult.cs#L47

I had some cases, where only a part of a sitemap was returned in a http response, because the task had not completed. Everything started working well after making this method async and awaiting all internal async calls.

uhaciogullari commented 4 years ago

Thanks for finding this. It was the same issue in #39 very probably. I pushed a new version to NuGet.