search

uhaciogullari / SimpleMvcSitemap

A minimalist library for creating sitemap files inside ASP.NET MVC and ASP.NET Core MVC applications
MIT License
128 stars 39 forks source link

Move completely to asp.net core 5 #44

Open mokeev1995 opened 4 years ago

mokeev1995 commented 4 years ago

This version is published on NuGet as SimpleMvcSitemap.Core

uhaciogullari commented 4 years ago

Hello Mokeev

The project is targeting netstandard1.6 and it should work with .NET Core 3.1 too. Did you run into a problem with that?

mokeev1995 commented 4 years ago

@uhaciogullari this project references old and currently unsupported libraries from Microsoft (e.g. Microsoft.AspNetCore.Mvc 1.0.3, System.Xml.XmlSerializer, System.Linq.Queryable).

So the point of this PR was to migrate to newer and supported libs and to get rid of the external unnecessary dependencies.

uhaciogullari commented 4 years ago

I think they will be overridden by the up to date packages that's referenced by your app. If I directly target .NET Core 3.1, it would break the compatibility with pre 3.1 projects. I don't want to do that just yet.

mokeev1995 commented 4 years ago

I think they will be overridden by the up to date packages that's referenced by your app.

That's the dark side of dll hell :)

If I directly target .NET Core 3.1, it would break the compatibility with pre 3.1 projects. I don't want to do that just yet.

Yeah, you do, but people can just use old version which still will be compatible with their apps. For instance, bump version to 5.0.

One more reason to upgrade: security reasons. Old ASP .Net Core lib can be (and possibly already is) vulnerable. There's so many security fixes to asp .net core applied from 1.0...

uhaciogullari commented 4 years ago

I'm pretty sure you are not using 1.x version of Microsoft.AspNetCore.Mvc package when you are running a .NET Core 3.1 app. You cannot have multiple versions of an assembly with a standard NuGet package setup. They will be overridden by the newer assemblies in your app. I have already updated the versions that had vulnerabilities, thanks to Github notifications. There is no reason for me to push a new version for now.

mokeev1995 commented 4 years ago

Ok, no problem, this PR can stay here for the future version, when it'll be needed :)

And my forked version (with replaced .net standard with .net core 3.1) will be on NuGet for some time while you don't upgrade to .net core or even .net 5 :)

SneezeWeeze commented 2 years ago

Any plan to push this out in 2022?

uhaciogullari commented 2 years ago

@SneezeWeeze Is there any problem you running into with the current version? Anything that you can't do that you need the changes here?

mokeev1995 commented 2 years ago

@SneezeWeeze you can just use SimpleMvcSitemap.Core (4.3 for .net 6 or .net 7, 4.2 for .net 6 or 4.1 for .net 5).

That's the same version as this PR suggests (You can check it out in links on nuget.org).