Closed alexander-haller closed 2 months ago
In GitLab by @mhxion on Jan 31, 2024, 20:34
Merges minor-improvements -> dev
Fixes #12
It might be better if we use base classes for a group of exceptions instead of individual exceptions, depending on the type of exception of course. This PR replaces httpx.ReadTimeout and httpx.ConnectTimeout with httpx.TimeoutException.
httpx.ReadTimeout
httpx.ConnectTimeout
httpx.TimeoutException
The exception hierarchy used by our HTTP library HTTPX is as follows (from site-packages/httpx/_exceptions.py):
site-packages/httpx/_exceptions.py
* HTTPError x RequestError + TransportError - TimeoutException · ConnectTimeout · ReadTimeout · WriteTimeout · PoolTimeout - NetworkError · ConnectError · ReadError · WriteError · CloseError - ProtocolError · LocalProtocolError · RemoteProtocolError - ProxyError - UnsupportedProtocol + DecodingError + TooManyRedirects x HTTPStatusError * InvalidURL * CookieConflict * StreamError x StreamConsumed x StreamClosed x ResponseNotRead x RequestNotRead
In GitLab by @mhxion on Jan 31, 2024, 20:34
Merges minor-improvements -> dev
Fixes #12
It might be better if we use base classes for a group of exceptions instead of individual exceptions, depending on the type of exception of course. This PR replaces
httpx.ReadTimeout
andhttpx.ConnectTimeout
withhttpx.TimeoutException
.The exception hierarchy used by our HTTP library HTTPX is as follows (from
site-packages/httpx/_exceptions.py
):