search

uhh-cms / cmsdb

CMS related campaigns, processes, cross sections and common definitions for analyses.
GNU General Public License v3.0
1 stars 16 forks source link

Rename data_pho -> data_gamma. #14

Closed riga closed 3 months ago

riga commented 1 year ago

With #13 close to being merged (among others, adding the data_egamma process), I noticed that the "single photon" process and some datasets are named data_pho(_*) which might be a bit inconsistent.

This PR renames all (not many though) occurrence to data_gamma.

dsavoiu commented 1 year ago

That's a fair point, although I think if we move from pho to gamma it will again be inconsistent with the SinglePhoton Primary Dataset name and thus the DAS keys.

In general I think it's a good idea to be consistent with DAS, as otherwise that might be confusing in particular for new users. So in this case I'm actually mildly in favor of keeping the pho-based names, but we can of course discuss if we would like to prioritize consistency across campaigns over names that more or less follow the DAS entry.

riga commented 1 year ago

Consistency with DAS is a good point. I think the issue will be (in potentially many place) that DAS is in itself inconsistent (EGamma, Photon, ...) 🫣

I think I'd be in favor of not passing down this inconsistency to users, but rather use the cmsdb as a "compensatory" layer. But this is quite a choice to make and we should discuss further.