search

uhh-cms / cmsdb

CMS related campaigns, processes, cross sections and common definitions for analyses.
GNU General Public License v3.0
1 stars 16 forks source link

Adding 2016 pre-VFP entries (v12) #21

Closed aalvesan closed 6 months ago

aalvesan commented 7 months ago

Adding the campaign run2_2016_HIPM_uhh_v12. Includes all cmsdb entries for data, signal and background for 2016 nanoAOD datasets, at version 12, and for pre-VFP era.

riga commented 7 months ago

This looks great @aalvesan 🎉 Could you add an entry to https://github.com/uhh-cms/cmsdb/blob/master/.github/workflows/lint_and_test.yaml#L61 so that the new campaign is covered by CI?

aalvesan commented 6 months ago

Hi @aalvesan, thanks for implementing the changes! Everything looks fine now, I just noticed a few minor things that should be easy to fix (see below).

Hi Daniel, thanks again for the review! I think I just removed all .pyc files. Let me know if there is something else that needs to be fixed :)

Cheers, Ana

dsavoiu commented 6 months ago

Hi @aalvesan, sorry for the delay in reviewing this. I actually noticed that I had overlooked some things in the initial review and also that the tests were failing due to some typos in the imports and missing processes. I took the liberty of committing a series of changes to fix these issues, so this should in principle now be ready to merge.

But @aalvesan please check if the changes work for you and I would also ping @riga and @pkausw here in case they also want to look over the changes before the merge.

dsavoiu commented 6 months ago

Hi @aalvesan, I fixed the conflicts with the master branch, which were due to the restructuring of unit tests introduced by #22. Did you manage to have a look at the latest changes? If there are no further things to do we could go ahead and merge this soon.