uhh-cms / cmsdb

CMS related campaigns, processes, cross sections and common definitions for analyses.
GNU General Public License v3.0
1 stars 16 forks source link

Generalize unit tests for campaigns #22

Closed pkausw closed 6 months ago

pkausw commented 7 months ago

Since cmsdb is growing quite rapidly, it's important to improve the test mechanism we have in place. Currently, the only thing that is tested is whether a campaign module can be imported, which already tests the most basic functionality. The list of tested modules is hardcoded.

This PR introduces a different approach based on python unittests. It introduces new tests for basic properties and datasets that are associated with a given campaign. Additionally, the campaigns to be tested are loaded automatically and are tested in parallel as a github action. This should simply adding and testing of new campaigns significantly.

pkausw commented 6 months ago

Thanks for commenting on the PR @dsavoiu - I had kind of forgotten about this one 😅 I went ahead and marked the conversations as resolved since we all kind of agree on the individual points. @mafrahm , if you have some remaining concerns, feel free to block this again! Otherwise, I'd suggest to merge this asap, perhaps tomorrow