search

uhlibraries-digital / greens

ARK identifier minter and resolver
MIT License
8 stars 3 forks source link

When 'naan' is empty string, an ark can not be deleted. #8

Closed medined closed 7 years ago

medined commented 7 years ago

When 'naan' is empty in the app.yaml, an ark like 'ark://57x43' is minted. However, when trying to delete that ark using curl, the two slashes are combined somewhere in the process. Therefore, the 'id' that is sought is 'ark:/57x43'. I see two possible resolutions, throw an exception when minted if the 'naan' is empty. Or mint the ark with only one slash in the special case when 'naan' is empty.

seanlw commented 7 years ago

The NAAN is a mandatory organization identifier. The ARK shouldn't have been minted in the first place if NAAN is empty.

Thanks for catching this!

medined commented 7 years ago

Would a Dockerfile be welcome? And a few bash functions to show how it works?

seanlw commented 7 years ago

Yes, they would be welcomed

medined commented 7 years ago

https://github.com/medined/docker-greens - I have a bash script that builds and starts an application stack. Please review it. Let me know if anything is unclear.