search

uhm-coe / authorizer

Authorizer is a WordPress plugin that uses Google, CAS, LDAP, or an OAuth2 provider for logins, and can prevent public access to a WordPress site. It also blocks repeated failed login attempts.
GNU General Public License v3.0
65 stars 38 forks source link

Make STARTTLS LDAP option more precise on UI #129

Closed TuringTux closed 1 year ago

TuringTux commented 1 year ago

Currently, the checkbox "Use TLS" enables STARTTLS:

https://github.com/uhm-coe/authorizer/blob/05bcdc6921478154232240fb52a464a34f172cd1/src/authorizer/options/external/class-ldap.php#L104

If the user specifies an ldaps:// connection, the checkbox has no effect:

https://github.com/uhm-coe/authorizer/blob/05bcdc6921478154232240fb52a464a34f172cd1/src/authorizer/class-authentication.php#L1105

In my opinion, the UI is not quite clear regarding these things. I would therefore propose the following changes:

If you want, I can try to open a PR with these particular changes.

figureone commented 1 year ago

Both those changes look reasonable, thanks! We'll get that added to the next version. Pull request would definitely be appreciated

TuringTux commented 1 year ago

I'll give it a shot as soon as I find the time (probably only in one or two weeks).

TuringTux commented 1 year ago

Done! #132 now contains the proposed changes (and attempts to localize them to Spanish and French, however, I am not too certain about them being correct).