search

uhm-coe / authorizer

Authorizer is a WordPress plugin that uses Google, CAS, LDAP, or an OAuth2 provider for logins, and can prevent public access to a WordPress site. It also blocks repeated failed login attempts.
GNU General Public License v3.0
65 stars 38 forks source link

Make STARTTLS LDAP option more precise on UI #132

Closed TuringTux closed 1 year ago

TuringTux commented 1 year ago

Closes #129.

This also attempts to provide Spanish and French translations, however, they should ideally be reviewed by someone with better knowledge of those languages.

TuringTux commented 1 year ago

I have manually changed the string in the .php file and in one translation file (authorizer.pot), however, that translation file seems to be automatically generated, so I probably need to try doing this with POedit.

Edit: Done. Running Poedit changed quite a lot in the .pot file, but I only committed the changes relevant to this proposal.

figureone commented 1 year ago

This looks great, thanks so much! It will be included in the next release

figureone commented 1 year ago

Re: Poedit, I'm running a pretty old version myself and I think a lot of the formatting of the .pot output has changed between versions. Thanks for trimming that down to just the relevant changes, makes the code review easier!

TuringTux commented 1 year ago

Thank you for merging!

Yes, that is also what I suspected. I apologize for the bigger Spanish and French translation files, they are not trimmed to the max, because I had to update them from the .pot file and then somewhat lost track over the changes.

figureone commented 1 year ago

Aloha, version 3.6.3 has now been released. Thanks so much for your contribution!

TuringTux commented 1 year ago

That's very nice, thank you! I've just checked it and our production WordPress instance has already updated to the latest version, looks very nice indeed :)