search

uhmanoa-transpiler-project / shaka-scheme

The official repository for the UH Manoa Transpiler Project's Scheme interpreter, Shaka Scheme.
32 stars 24 forks source link

Pull request GCList #56

Closed bmwfire closed 6 years ago

bmwfire commented 6 years ago

I have completed my tasks, GCList.cpp and unit-GCList.cpp. Please note that I also added two other methods to GCList.hpp, called is_empty() and get_size().

is_empty() checks the GCList and verifies whether or not it is empty. get_size() simply allows access to the private size data.

In addition to those two added methods, this cpp file includes the constructor, destructor, add_data(GCData *data), and sweep() methods. Let me know if there are any questions or concerns.

bmwfire commented 6 years ago

Ok excellent. I'm noticing that GitHub is giving me an error check for my final commit. Should I be concerned of this?

btwooton commented 6 years ago

@bmwfire The error in the travis-ci build is due to a broken unit test in the MacroContext code. The build will not pass until this unit test is fixed by @VermillionAzure. I have added him as a reviewer as I believe he is the only one able to merge your PR despite the failing build. All of your unit tests are passing, so don't worry about it.

CinchBlue commented 6 years ago

I'm on duty now. I will fix the unit test now.

CinchBlue commented 6 years ago

I have finished a pull request to fix the MacroContextChecker unit test case in order to solve the error that is stopping this from merging. Thus, I am blocking you until the pull request is finished (it shouldn't take long, whoever wants to review it). Sorry for the inconvenience 🙁

https://github.com/uhmanoa-transpiler-project/shaka-scheme/pull/57

bmwfire commented 6 years ago

I'm reviewing it now. @VermillionAzure

bmwfire commented 6 years ago

@VermillionAzure There seems to be new errors despite your changes.

btwooton commented 6 years ago

The build failed at apt-get install gcc-6

bmwfire commented 6 years ago

Yes I saw that. How do we fix it?

CinchBlue commented 6 years ago

Just had to rerun the build. It appears to be passing now.

CinchBlue commented 6 years ago

Since Troy already reviewed this, I will squash and merge the changes into master. Good job @bmwfire !