search

uhooi / UhooiPicBook

Uhooi's character book.
MIT License
108 stars 25 forks source link

Remove unnecessary [weak self] #259

Closed uhooi closed 2 years ago

uhooi commented 2 years ago

Overview

freddi さんの指摘に対応した。

ここですが、weak self は基本内側のクロージャに伝播するので外側で weak self していれば問題ないです　例外として外側でguard let self = self してる時などは必要です

codecov[bot] commented 2 years ago

Codecov Report

Merging #259 (c3adc2f) into develop (248e866) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #259   +/-   ##
========================================
  Coverage    52.84%   52.84%           
========================================
  Files           10       10           
  Lines          193      193           
  Branches        86       86           
========================================
  Hits           102      102           
  Misses          91       91

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 248e866...c3adc2f. Read the comment docs.