uhooi / UhooiPicBook

Uhooi's character book.
MIT License
107 stars 25 forks source link

Manage project with SwiftPM #277

Closed uhooi closed 2 years ago

uhooi commented 2 years ago

Issue

Details

codecov[bot] commented 2 years ago

Codecov Report

Merging #277 (180c6a7) into develop (97d8566) will decrease coverage by 3.69%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #277      +/-   ##
===========================================
- Coverage    59.58%   55.89%   -3.70%     
===========================================
  Files           12       11       -1     
  Lines          292      263      -29     
  Branches       111      104       -7     
===========================================
- Hits           174      147      -27     
+ Misses         118      116       -2     
Impacted Files Coverage Δ
...IntentDefinition/MonsterIntentObject+Convert.swift 0.00% <ø> (ø)
...ppModule/Extensions/Foundation/Bundle+String.swift 66.66% <ø> (ø)
...erDetail/Interactors/MonsterDetailInteractor.swift 0.00% <ø> (ø)
...onsterList/Interactors/MonsterListInteractor.swift 100.00% <ø> (ø)
.../MonsterList/Presenters/MonsterListPresenter.swift 92.15% <ø> (ø)
...ule/Repository/Spotlight/SpotlightRepository.swift 15.62% <ø> (ø)
...Cache/Extensions/Foundation/URLSession+Async.swift 69.23% <ø> (ø)
Sources/ImageCache/ImageCacheManager.swift 34.61% <66.66%> (ø)
...sterDetail/Presenters/MonsterDetailPresenter.swift 100.00% <100.00%> (ø)
...AppModule/Repository/Temp/UserDefaultsClient.swift 91.66% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97d8566...180c6a7. Read the comment docs.

uhooi commented 2 years ago

@treastrain 知りませんでした、ありがとうございます! https://github.com/uhooi/UhooiPicBook/pull/277/commits/c4bac11f75df8b3a0846db9115a31ab7ce8c2046 で修正しました。