uhooi / UhooiPicBook

Uhooi's character book.
MIT License
107 stars 25 forks source link

cleanup dependencies by Carthage #94

Closed 417-72KI closed 3 years ago

417-72KI commented 3 years ago

Carthage frameworks can be integrated more easier.

ref: https://github.com/yonaskolb/XcodeGen/blob/master/Docs/Usage.md#carthage

uhooi commented 3 years ago

Thanks for PR :) CI failed, re-run all jobs now.

uhooi commented 3 years ago

@417-72KI やはりテストが失敗しますね。 CIの失敗部分の結果のみ抜粋します↓

Testing failed:
    UhooiPicBookTests:
        UhooiPicBook.app encountered an error (Failed to install or launch the test runner. If you believe this error represents a bug, please attach the result bundle at /Users/runner/Library/Developer/Xcode/DerivedData/UhooiPicBook-drfsvafebgsoehekifuhzwqlnnpn/Logs/Test/Run-UhooiPicBook-2020.09.28_07-04-50-+0000.xcresult. (Underlying Error: This app could not be installed at this time. Could not install at this time. Failed to load Info.plist from bundle at path /Users/runner/Library/Developer/XCTestDevices/3B29FAB5-6C3D-4771-881D-73AA5C836920/data/Library/Caches/com.apple.mobile.installd.staging/temp.500Fo6/extracted/UhooiPicBook.app/Frameworks/gRPC-C++.framework; Extra info about Info.plist: dev=16777221 ino=12895181934 mode=0100644 nlink=1 uid=501 gid=20 rdev=0 size=605 atime=1600279824.000000 mtime=1600278877.000000 ctime=1601276813.412971 birthtime=1600278877.000000 blksize=4096 blocks=8 flags=0x0 firstBytes={length = 4, bytes = 0x3c3f786d} ACL=<not found> extendedAttributes=<not found> keyCount=7 keySample={ CFBundleIdentifier DTSDKName CFBundleName CFBundleInfoDictionaryVersion CFBundleExecutable } . (Underlying Error: Failed to load Info.plist from bundle at path /Users/runner/Library/Developer/XCTestDevices/3B29FAB5-6C3D-4771-881D-73AA5C836920/data/Library/Caches/com.apple.mobile.installd.staging/temp.500Fo6/extracted/UhooiPicBook.app/Frameworks/gRPC-C++.framework; Extra info about Info.plist: dev=16777221 ino=12895181934 mode=0100644 nlink=1 uid=501 gid=20 rdev=0 size=605 atime=1600279824.000000 mtime=1600278877.000000 ctime=1601276813.412971 birthtime=1600278877.000000 blksize=4096 blocks=8 flags=0x0 firstBytes={length = 4, bytes = 0x3c3f786d} ACL=<not found> extendedAttributes=<not found> keyCount=7 keySample={ CFBundleIdentifier DTSDKName CFBundleName CFBundleInfoDictionaryVersion CFBundleExecutable } )))

** TEST FAILED **

make: *** [test] Error 65
Error: Process completed with exit code 2.

ちなみに私も以前同じようなことを試したのですが、ビルドが通らなくて諦めました、、 https://github.com/uhooi/UhooiPicBook/commit/7c6cd467f513d59472fc1ba75abdb903769745a6

417-72KI commented 3 years ago

実践済み失礼しました😅 しかし謎エラーすぎますね...

Xcode12絡みなのかと思いましたが5月の時点で同じならそういうわけでも無さそうですし🤔

SwiftPMに移行するIssueもあるようですし、こいつは取り下げますね🙇‍♂️

uhooi commented 3 years ago

ホント謎なんですよね… 取り下げりょうかいです、PRありがとうございましたー!