search

uhop / node-re2

node.js bindings for RE2: fast, safe alternative to backtracking regular expression engines.
Other
495 stars 53 forks source link

Update re2.d.ts #101

Closed BannerBomb closed 3 years ago

BannerBomb commented 3 years ago

I updated the TypeScript definitions to add the extended methods and properties that were added.

uhop commented 3 years ago

Is there any way to ensure that the new bindings work properly? It can be a TS file (not part of this patch) that uses RE2 differently and runs properly. I am kind of afraid to break existing TS users.

BannerBomb commented 3 years ago

You could make a development branch to push developmental changes to before pushing it to the master branch.

But the typings still extends off of the RegExp definitions just with additional properties/methods added to it. The only way it should break is if the other definition has a property/method of the same name but a different type.