search

uhop / node-re2

node.js bindings for RE2: fast, safe alternative to backtracking regular expression engines.
Other
489 stars 53 forks source link

TS fixes #142

Closed uhop closed 1 year ago

uhop commented 1 year ago

A replacement for #141 and #134.

uhop commented 1 year ago

I would appreciate it if @kachick and @JamieMagee tested this PR to ensure it catches fixes in your respective PRs.

JamieMagee commented 1 year ago

@uhop I validated that the updated types work with TypeScript 4.9

JamieMagee commented 1 year ago

@uhop If you're happy, can you merge this please?

kachick commented 1 year ago

I have checked #134 patches are still active in this PR 👍

I would add one point, adding CI would be better, to run the new ts-test script as noted as https://github.com/uhop/node-re2/pull/134#pullrequestreview-1111664732.