uhop / node-re2

node.js bindings for RE2: fast, safe alternative to backtracking regular expression engines.
Other
479 stars 53 forks source link

Much slower install time on node v20 #197

Closed skutyepov closed 8 months ago

skutyepov commented 8 months ago

I noticed that the time to install re2 on node v20 went up significantly as compared to node v18. It happens on my local intel based OS X machine as well as in Docker with amd64/ubuntu:jammy.

It takes 7s to install on node v18:

node --version
v18.18.2
npm --version
10.2.3
npm install --save re2@1.20.7

added 103 packages, and audited 104 packages in 7s

npm ci

added 103 packages, and audited 104 packages in 2s

and 2 minutes on node v20:

node --version 
v20.9.0
npm --version
10.2.3
npm i --save re2@1.20.7

added 103 packages, and audited 104 packages in 2m

npm ci

added 103 packages, and audited 104 packages in 2m
uhop commented 8 months ago

Likely this PR will fix it: https://github.com/uhop/install-artifact-from-github/pull/5 — coming soon.

uhop commented 8 months ago

Published as 1.20.8. Please test and let me know if it helps in your case.

skutyepov commented 8 months ago

It's fixed now. Thank you so much!