fix: remove npm from install script

uhop / node-re2

node.js bindings for RE2: fast, safe alternative to backtracking regular expression engines.

Other

479 stars 53 forks source link

Closed styfle closed 5 months ago

styfle commented 5 months ago

The install script will fail when using a package manager other than npm (such as yarn or pnpm) through corepack.

Usage Error: This project is configured to use pnpm

It will also fail in the case when npm is not installed at all.

zsh: command not found: npm

This change should also be a tiny bit faster since it invokes node-gyp directly instead of relying on npm to invoke it.

mshick commented 5 months ago

I'm encountering this issue. Same situation as OP, corepack-enabled pnpm. Would love to see this merged.

styfle commented 5 months ago

@uhop Can you take a look when you have a moment? Thanks!

uhop commented 5 months ago

I want to release the latest three patches together. That's why a holdup.

uhop commented 4 months ago

Published as 1.20.10.