Resources & Taxation diagram

[thom5468]

Since this issue has been closed i am opening another. This diagram has an odd relationship statement that requires a closer look. I don't think spending force points should inherit the qualities of military units and PDB repairs. I think this is a user defined relationship where spending gets you military units and repairs/upgardes.

I would like to gain agreement on this before I make these adjustments.

[hallister]

I took a closer look at this and your right. This is too much of an activity diagram and not a class diagram. I wonder if this makes more sense:

Force Points < Reduce Item Force Points < Increase Taxation Force Points < Increase Resource Gathering

PDB Inherits Item Military Unit Inherits Item Rebel Unit Inherits Item Imperial Unit Inherits Item

Imperial Special Unit Inherits Imperial Unit (This replaces Imperial Galactic Spending) Maintenance Inherits Imperial Special Unit

The Attributes/Methods won't change much, but this really is an activity diagram as-is and may hurt grading.

[thom5468]

I think they made this way harder than it needed to be. Heres what im thinking:

force pts--<>resources mil units--<>resources char --<>resources taxation = method of resource forces pts(spend)---(receive)mil units/upgrades/repairs

This is the direction im going.

[hallister]

I'd still have Taxation as a class since it has state (ImperialControl [Bool], Amount [Enum]). Otherwise I think yours is probably closer to correct.

[jleithart]

@thom5468 If I'm reading your suggestions correctly, you want to make resources an aggregate of force pts (a class?) military units (a class?) and a character (another class?)?

Taxation is not the only method of gathering a resource (which is why it became difficult for us to create the diagram). The Rebel player gathers resources by starting rebellions, while the Imperial player gathers resources by taxation (galactic) If it's a Province game, both players gather resources according to the Scenario's rules, while in a Star System game resources are only gathered by the Rebels when they start a rebellion and the Imperials don't get to gather any resources.

This biggest problem that we ran into while doing this is that Resources touches on a ton of other aspects of the game. Military units, player, faction, and planets are the ones that I can think of off the top of my head. We attempted to make it as object oriented as possible because that was how I read the assignment.

I believe that if someone had tagged me by saying @leit7193 in one of the comments, I would have been notified and I could have attempted to fix some of the issues before we handed it in.

[hallister]

Dr. J's notes are available at #34.

[jleithart]

Thank you!

[jleithart]

@hall5714 Should I do a pull request to master for this to be looked over or is it fine here?

[hallister]

@leit7193 I'll pull and merge it today when I get this stuff all together.

[jleithart]

@hall5714 Perfect, just let me know if anything needs to be changed and I'll happily fix it