search

ui-cs383 / Freedom-Galaxy

Primary repository for the FitG
1 stars 6 forks source link

YAML Implementation of Flight of Egrix #39

Open hallister opened 10 years ago

hallister commented 10 years ago

I haven't had a chance to follow up with you. I think this might be easier to store in a single file (fofe.yaml or something) or as a folder with various YAML files in it (planets.yaml, characters.yaml) etc?

Greg-Donaldson commented 10 years ago

Woah... wait a second. You want ALL the .dat files converted to yaml? I thought you just wanted the scenario files converted over?

hallister commented 10 years ago

Sorry, I missed this somehow.

We want to be able to load a SINGLE file that will store all data about a given scenario (The Planets, Characters, etc). Each scenerio should be self containing.

Greg-Donaldson commented 10 years ago

...Considering your other post regarding breaking changes, I'm going to talk to you about this on Tuesday.

Greg-Donaldson commented 10 years ago

Alright, I have Egrix pretty much ready to go, though I am running into problems getting the monsters set up, specifically the Drant (since they do something really specific). Does anyone mind if I change the monster, or did you have something in mind for monsters, @hall5714?

hallister commented 10 years ago

@Greg-Donaldson Have at it lol.

andyleejordan commented 10 years ago

I'm just seeing this issue, apparently GitHub failed at sending out emails. For what it's worth, changing to YAML, even at the point this issue was posted, is a bad idea. What are the reasons for it? I thought it'd been decided that scenarios would be in the database with everything else.

hallister commented 10 years ago

@andschwa Our entire implementation depends on scenarios being stored outside of the database. However, the .dat files were terrible.

The opportunity to discuss this was two weeks ago when it was posted. The fact that you did not check it until today doesn't change that.

@Greg-Donaldson Thanks for working on this! We may remove the races part as those really don't change, and instead just load all races into the database at all times. Otherwise, looks awesome.

Greg-Donaldson commented 10 years ago

You mean monsters, @hall5714?

hallister commented 10 years ago

@Greg-Donaldson What I meant is that all races will always be in the database, so we don't need to specify them in the config files. Since their only interest is their relationship to environ, we just join enviorn to the race and we're good to go.

Greg-Donaldson commented 10 years ago

Ah, alright. I will remove the race from the .yaml and push up my new copy. Now with military units!

[EDIT]: Actually, now that I think about it, I'm not sure which field you are talking about? So I'm just going to upload it and let you delete the fields.

andyleejordan commented 10 years ago

I wasn’t notified that it went up, it was a miscommunication. Regardless, the dat files aren’t terrible at all, quite easily parsed. But let’s move on.

Where are we with the YAML implementation, and what needs to be done next?

On Dec 6, 2013, at 12:53 PM, Justin Hall notifications@github.com wrote:

@andschwa Our entire implementation depends on scenarios being stored outside of the database. However, the .dat files were terrible.

The opportunity to discuss this was two weeks ago when it was posted. The fact that you did not check it until today doesn't change that.

@Greg-Donaldson Thanks for working on this! We may remove the races part as those really don't change, and instead just load all races into the database at all times. Otherwise, looks awesome.

— Reply to this email directly or view it on GitHub.

Greg-Donaldson commented 10 years ago

Alright, completed copy pushed. If you have any questions, please ask. The database might need to be updated to handle military units and monsters.

Were there any other scenarios you wanted me to work on, or should I start working on other .dat file to yaml conversions, or, should I start working on documentation?

hallister commented 10 years ago

@Greg-Donaldson The only .dat file to .yaml conversions we should need is for Race. If you want to work on a race.yaml file that would be awesome.

@andschwa That's all we need for the time being.

Greg-Donaldson commented 10 years ago

@hall5714: races.yaml complete. Egrix.yaml edited, races removed (environ ID for each race is no longer needed, as a note). Just have to run a simple match for Environ and Race (combining the environ's race name with an underscore and the environ type).