search

ui-ninja / react-native-rating-element

A simple rating library for react native supporting: decimal points, direction aware icons, custom icon set from Ionicons, custom images and record rating given by users.
MIT License
25 stars 5 forks source link

onIconTap is not a function #16

Closed Relax594 closed 4 years ago

Relax594 commented 4 years ago

Running this

<Rating size={48} totalCount={1} rated={stern1} />

and clicking on it crashes the app because of

ERROR TypeError: onIconTap is not a function. (In 'onIconTap(position + 1)', 'onIconTap' is undefined)

There is never a check if this function exists and from reading the docs there is no need to define this function.

Please either check if the function exists (which should be the way to go anyways) or update the docs :) Thanks!

ui-ninja commented 4 years ago

Good catch.. Will fix and revert soon.

ui-ninja commented 4 years ago

Fixed. Check v5.3.2

Relax594 commented 4 years ago

LGTM