search

ui-router / angular-hybrid

Upgrade an ng1 UI-Router app to a ng1+ng2 hybrid using ng-upgrade
MIT License
167 stars 75 forks source link

Angular7 is support or not? #236

Closed y8n closed 5 years ago

y8n commented 5 years ago

Will ui-router/angular-hybrid support Angular7?

scottnice commented 5 years ago

Ditto

rbnzdave commented 5 years ago

doesnt seem like it

icorne commented 5 years ago

What seems to be your issues? I'm using it with angular 7

david-meza commented 5 years ago

It is working for me with Angular 7 as well. There's just a warning when running npm commands, but the library itself seems to be compatible.

npm WARN @uirouter/angular-hybrid@6.0.2 requires a peer of @angular/core@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.

rbnzdave commented 5 years ago

I find I cant even install it, as there are requirements for angular6 from memory latest PR to make it compatable with ng7 was denied from a few sources. havent re-looked in a while

rbnzdave commented 5 years ago

yeah there are still a bunch of open PR's mentioning getting it to support 7. This was what I was referring to.

ngehlert commented 5 years ago

angular 7 support for the core ui router just came by last week (https://github.com/ui-router/angular/issues/423)

@christopherthielen sorry to ping you in two different issues. can you please add support for angular 7 for the hybrid router. thanks in advance

christopherthielen commented 5 years ago

https://github.com/ui-router/angular-hybrid/releases/tag/7.0.0

ngehlert commented 5 years ago

awesome thanks