search

ui-router / angular-hybrid

Upgrade an ng1 UI-Router app to a ng1+ng2 hybrid using ng-upgrade
MIT License
167 stars 75 forks source link

chore: Angular 16 support #589

Closed boxmein closed 1 year ago

boxmein commented 1 year ago

This PR implements Angular 16 support.

Once the sample app (https://github.com/ui-router/sample-app-angular-hybrid/pull/914) is updated, this PR is also mergeable

Fixes #588

boxmein commented 1 year ago

Taking care of https://github.com/ui-router/sample-app-angular-hybrid/issues/913

wawyed commented 1 year ago

hmm looks like the example is failing.

wawyed commented 1 year ago

I figure it out, you need to update:

"webpack": "^5.77.0",
"webpack-cli": "^5.0.1",
"webpack-dev-server": "^4.13.2"

in the examples package.json
boxmein commented 1 year ago

Thanks so much. If it's OK I will pick it up after my vacation, at the 2nd week of August.

boxmein commented 1 year ago

Testing locally, with your recommended changes, the test:downstream NPM script started passing.

wawyed commented 1 year ago

Hi, can you change the downstream test to uirouter I just merged it.

boxmein commented 1 year ago

Thanks @wawyed, I'll take care of it.