search

ui-router / angular-hybrid

Upgrade an ng1 UI-Router app to a ng1+ng2 hybrid using ng-upgrade
MIT License
167 stars 75 forks source link

feat: Angular 17 support #595

Closed vanhorickanthony closed 5 months ago

vanhorickanthony commented 6 months ago

This PR adds support for Angular v17.

Fixes https://github.com/ui-router/angular-hybrid/issues/594.

lievenjanssen commented 5 months ago

@wawyed can this be merged or is there anything that still needs to be done?

wawyed commented 5 months ago

@lievenjanssen test-downstream needs to be sorted out

vanhorickanthony commented 5 months ago

@wawyed The downstream test fails because of incompatible peer dependencies between version 16 and 17 - you can however successfully run the tests locally by substituting the hybrid UI router dependency for the local version. The tests currently use the latest released version which is still V16 - while the version being tested is V17.

wawyed commented 5 months ago

You need to create a PR there such as https://github.com/ui-router/sample-app-angular-hybrid/pull/914

kburczyk commented 5 months ago

@vanhorickanthony Thank you very much, for this update. I'm desperately waiting for it. Do you know, when it will be merged?

vanhorickanthony commented 5 months ago

@wawyed Alright, thanks. A PR has been created as requested, and can be tracked here https://github.com/ui-router/sample-app-angular-hybrid/pull/916.

lievenjanssen commented 5 months ago

@wawyed is the requested PR on the sample app ok? Is there anything still needed to move on with merging this?

wawyed commented 5 months ago

@wawyed is the requested PR on the sample app ok? Is there anything still needed to move on with merging this?

Just trying to figure out why is it failing now.