chore: Angular 16 support

ui-router / angular

UI-Router for Angular: State-based routing for Angular (v2+)

https://ui-router.github.io/ng2/

MIT License

353 stars 134 forks source link

chore: Angular 16 support #985

Closed boxmein closed 1 year ago

boxmein commented 1 year ago

This PR makes ui-router/angular target Angular 16 in peerDependencies and during development.

Fixes #984

[x] Update dependencies to Angular 16
[x] Update Jest, jest-preset-angular and test body to match Angular 16
[x] Bump major version (because of peerDependency changes)
[x] test-typescript-versions 4.9 generated
[x] test-angular-versions 16 generated
[x] These sections are not completed: https://github.com/ui-router/angular/blob/master/add_support_for_new_angular_version.txt#L21-L50

I've verified that the commits build and tests are passing. Where documentation was mentioning entryComponents, it was updated to remove such mentions.

boxmein commented 1 year ago

@wawyed Now I'm stuck because it appears test:downstream cannot be completed without updating sample apps to Angular 16. And sample apps can't be updated because an Angular 16 compatible ui-router is not available.

wawyed commented 1 year ago

We need to do the examples in order to get the build to pass

wawyed commented 1 year ago

@wawyed Now I'm stuck because it appears test:downstream cannot be completed without updating sample apps to Angular 16. And sample apps can't be updated because an Angular 16 compatible ui-router is not available.

@boxmein create a branch with the changes to 16 for the sample angular example and then reference it in the test downstream json file. Don't worry about that as the script will use the local version when testing which is 16 compatible.

boxmein commented 1 year ago

Right now it looks like the v16 run completed thanks to your review. What are the next steps for me?

wawyed commented 1 year ago

I just merged the sample-app-angular can you change the test_downstream.json

boxmein commented 1 year ago

Will do, just a moment