search

ui-router / quickstart-ng2

DEPRECATED -- See https://github.com/ui-router/quickstart-angular
https://github.com/ui-router/quickstart-angular
MIT License
64 stars 20 forks source link

upgrade to use ng2.rc1 #2

Closed earlyster closed 8 years ago

earlyster commented 8 years ago

I tried to upgrade to RC1 but looks like ui-router version 1.0.0-alpha.5 is not out yet

earlyster commented 8 years ago

I did a first pass (manually copied npm module) https://github.com/earlyster/quickstart-ng2/commit/2fc06a30dbc676dbfb46fc32d007ecd15aee6b07

There are some issues with README still didn't resolve those conflicts.

christopherthielen commented 8 years ago

Thanks for that!! I have already updated QuickStart in a local branch. Will push as soon as alpha.5 lands.

Alpha.5 is blocked on html5 push state support. If that doesn't happen before Friday ill release .5 without push state.

I wish I had more time... Apologies.

earlyster commented 8 years ago

No problem thanks for quick reply

earlyster commented 8 years ago

Hi @christopherthielen are there instructions to build the ui-router-ng2 npm module so I can just use it locally and link to it... I tried using ui-router build but couldn't figure out where the module was created.

christopherthielen commented 8 years ago

@earlyster run ./scripts/package.js ng2 then your built package will be in build_packages/ng2

christopherthielen commented 8 years ago

@earlyster also, I plan to release alpha.5 very soon (later today?)

christopherthielen commented 8 years ago

alpha.5 released, and quickstart-ng2 updated

earlyster commented 8 years ago

Thx

christopherthielen commented 8 years ago

Somebody on gitter said there is a problem with the QuickStart. Going to look into it in the morning. On Thu, May 12, 2016 at 11:02 PM Justin Early notifications@github.com wrote:

Thx

— You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub https://github.com/ui-router/quickstart-ng2/issues/2#issuecomment-218947180

christopherthielen commented 8 years ago

quickstart is fixed (had to pin the rxjs dependency)