refactor: fixed some things that slipped through my review in #230 - Githubissues

ui5-community / bestofui5-website

"Best of UI5" is the new entry page for the ui5-community.

https://bestofui5.org

Apache License 2.0

27 stars 3 forks source link

refactor: fixed some things that slipped through my review in #230 #238

Closed wridgeu closed 2 years ago

wridgeu commented 2 years ago

Hi Marian,

I just realized something and thought I might fix that real quick, I forgot something when checking out the PR earlier. :)

added i18n to text prop
removed title prop in page as it is not required anymore, see: https://sapui5.hana.ondemand.com/#/api/sap.m.Page%23aggregations:~:text=is%20not%20sufficient.-,If%20this%20aggregation%20is%20set%2C%20the%20simple%20properties%20%22title%22%2C%20%22showNavButton%22%2C%20%22NavButtonText%22%20and%20%22icon%22%20are%20not%20used.,-footer