Closed marianfoo closed 2 years ago
Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-forest-06ce4fe10-268.centralus.1.azurestaticapps.net
Hey @petermuessig have a look: https://yellow-forest-06ce4fe10-268.centralus.1.azurestaticapps.net/#/contributors need some better styling
Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-forest-06ce4fe10-268.centralus.1.azurestaticapps.net
@petermuessig tried my best with my minimal css skills to improve it have a look now
Hey @marianfoo
looks already a lot better! :)
You know what comes next, right? Dark mode might need a few more tweaks. :D
other minor things that got my attention are...
I think the full space should be used here or does it lead to a weird look in regards to the spacing between each avatar?
The padding used offsets everything from the "Expand Details" Button position which makes it look a bit off - but maybe I'm just way too picky ^^"
If time allows I might try and check some of the changes myself and see if they'd even look good, after all my css skills are limited as well and I am much like yourself not a professional designer :D
BR :)
You know what comes next, right? Dark mode might need a few more tweaks. :D
Ah, damnit, always forget dark mode, good catch.
I put those paddings and margin there on purpose because it was just too tight there. But you can try out if you find some better layout: https://github.com/ui5-community/bestofui5-website/blob/5916cb19c00db91307992cbba624b9457b29462a/src/css/style.css#L199-L206
Need to add the prefers-color-scheme
in there
Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-forest-06ce4fe10-268.centralus.1.azurestaticapps.net
Looks awesome +2
Changes