search

ui5-community / bestofui5-website

"Best of UI5" is the new entry page for the ui5-community.
https://bestofui5.org
Apache License 2.0
27 stars 3 forks source link

refactor: use new icon registry (webc) #308

Closed wridgeu closed 1 year ago

wridgeu commented 1 year ago

Hi Marian,

I did some minor changes to the timeline view and made use of the new iconRegistry. I got rid of some of the Promise based logic as I think (but maybe I'm wrong, please correct me!) that this is not needed because everything is required/loaded in onInit (so basically immediately) when opening the view anyway.

Additionally I bumped the version of the types (or rather pushed the package-lock as this was forgotten on 107). I also made some minor adjustments to the Timeline view i.e.: removing unused namespaces and some test function call where a teststring was passed.

PS: I forgot to create a new branch on my fork but that shouldn't get me in trouble :D

BR Marco

marianfoo commented 1 year ago

Hey, thanks for the pull request. I wanted to do that for a long time. But unfortunately I don't see the icons in the timeline locally anymore. Does it work for you?

Can you please merge the PR so that the merge conflict is fixed. https://github.com/wridgeu/bestofui5-website/pull/2 Thank you!

wridgeu commented 1 year ago

Hey! Odd ... it "worked on my machine" 🤪 -- I'll have a look at it again, probably during the weekend though. I'll go ahead and do the merge then as well. Thanks!

wridgeu commented 1 year ago

Hi again,

I merged the dependency bump (ty for the PR :P).

I tested the change locally on Chrome, Edge and Firefox with completely emptied out cache + hard refresh as well as in incognito mode. Just to be sure I also deleted the webapp folder and reran everything.

image

Is there any error you observe in the console or maybe network or smth.?

marianfoo commented 1 year ago

You´re right, it works in #312 when i deploy it to Azure Will merge, Thanks!