search

ui5-community / bestofui5-website

"Best of UI5" is the new entry page for the ui5-community.
https://bestofui5.org
Apache License 2.0
27 stars 3 forks source link

chore: bump ui5, tooling and wdi5 versions #315

Closed wridgeu closed 10 months ago

wridgeu commented 1 year ago

For fixing the wdi5 tests on #314 I bumped the UI5, wdi5, UI5 tooling and a few other versions. Some version conflict with newest wdio & wdi5 or prettier with pretty-quick were also resolved (no mindless full bump).

I did not bump any action and therefore no node or action versions though. Two tests which relied on virtual list items (clones) were made more resilient by ignoring the clone id at the end. These sporadically failed for me.

Locally it all passed, several times

Spec Files:      5 passed, 1 skipped, 6 total (100% completed) in 00:00:44

Disclaimer

I did not comb through the entire codebase to clean up or "migrate" types or anything but it still seemed to work just fine. ^^

Hope it helps a bit.

wridgeu commented 1 year ago

Interesting that it still fails ... but it looks to me like the start of the app takes a bit longer and the testing begins too soon? 🤔 Locally it simply works using npm run start:test and after everything has started npm run test.

wridgeu commented 1 year ago

Interesting that it still fails ... but it looks to me like the start of the app takes a bit longer and the testing begins too soon? 🤔 Locally it simply works using npm run start:test and after everything has started npm run test.

Guess that was it. Added wait-on as devDep in bc556a9