search

ui5-community / generator-ui5-project

Generator for UI5-based web-apps which use the official UI5 tooling and support multiple deployment targets such as the SAP Business Technology Platform
Apache License 2.0
33 stars 25 forks source link

remove app from xml views #29

Closed lboehm closed 2 years ago

nicoschoenteich commented 2 years ago

Hi @lboehm, one of the tests was failing, because we now miss the id in the newly generated view. Could you add id="<%= isSubgeneratorCall ? 'idAppControl' : viewname %>" in the <Page /> tag? It makes sense to keep the id for routing purposes, doesn't it?

lboehm commented 2 years ago

Hi @nicogeburek.

I think we have two options:

  1. The ID isn't necessary for routing, so we can dismiss it.
  2. We can keep the ID, because it doesn't hurt either. But currently the ID is set on the <App> (see this link), but the <App> was deleted (see this link, so we would have to add it to the <Page> tag.

Which way do you prefer?

BTW: when running the unit tests locally, it takes ages and sometimes they're running into timeouts. Is this just me?

wridgeu commented 2 years ago

Hi @lboehm 👋

BTW: when running the unit tests locally, it takes ages and sometimes they're running into timeouts. Is this just me?

It's the same for me, just wanted to throw that out there :P

BR :)

nicoschoenteich commented 2 years ago

Hi @lboehm,

I think I prefer option 2.

And yes, the tests take ages for me too...

lboehm commented 2 years ago

Hi @nicogeburek

I've provided a commit that adds the ID again. I'm facing quite some issues running the unit tests locally. So I hope the tests will now pass. In the meantime I will try to figure out how to run the tests successfully.

BR Lukas

nicoschoenteich commented 2 years ago

https://github.com/ui5-community/generator-ui5-project/issues/21